Login Page - Create Account

Support Board


Date/Time: Mon, 23 Dec 2024 20:07:11 +0000



bug report: CalculateDailyOHLC

View Count: 894

[2015-10-22 01:10:43]
jesslinn - Posts: 108
This is of no consequence to me and I do not need a response, unless you would rather not see support requests like this or would rather get an email instead.

There is a problem in the CalculateDailyOHLC function in scstudyfunctions.cpp, where the else clause following "if (!UseDaySessionOnly)" refers to the StartDateTime and EndDateTime of the session without setting them to the session start and end times.

The result is that if one turns on UseDaySessionOnly in scsf_DailyOHLC for a symbol where the start session time is after the end session time (previous day) the function and study will not work.
[2015-10-22 03:03:38]
Sierra Chart Engineering - Posts: 104368
Interesting this went unnoticed.

It is now fixed:

  
SCDateTime StartDateTime;

SCDateTime EndDateTime;

if(sc.StartTime1 <= sc.EndTime1)
{
  StartDateTime.SetDate(ReferenceDay);
  StartDateTime.SetTime(sc.StartTime1);

  EndDateTime.SetDate(ReferenceDay);
  EndDateTime.SetTime(sc.EndTime1);
}
else
{
  StartDateTime.SetDate(ReferenceDay - 1);
  StartDateTime.SetTime(sc.StartTime1);

  EndDateTime.SetDate(ReferenceDay);
  EndDateTime.SetTime(sc.EndTime1);
}

Although thinking about this, really there should never be a problem because the day session times really should never be reversed if one is using the UseDaySessionOnly option to begin with.
Sierra Chart Support - Engineering Level

Your definitive source for support. Other responses are from users. Try to keep your questions brief and to the point. Be aware of support policy:
https://www.sierrachart.com/index.php?l=PostingInformation.php#GeneralInformation

For the most reliable, advanced, and zero cost futures order routing, *change* to the Teton service:
Sierra Chart Teton Futures Order Routing
Date Time Of Last Edit: 2015-10-22 03:05:12
[2015-10-22 09:53:21]
jesslinn - Posts: 108
Start and end times can be reversed if say you have set up split session times for Asian markets and are using a US time zone.

To post a message in this thread, you need to log in with your Sierra Chart account:

Login

Login Page - Create Account