Support Board
Date/Time: Wed, 15 Jan 2025 18:06:18 +0000
Post From: GlobalSymbolSettings.xml should be written out with a temp file then replaced on success
| [2017-07-03 19:03:31] |
| i960 - Posts: 360 |
|
This is all that matters: Do you use a temp file or not? If you write to an in-place file using something like an XML output function (or whatever) that *could* fail part way through you're bound to end up with a corrupted file at some point. It doesn't matter if it's never been seen before, I'm telling you that programmatically it can happen because the approach relies on everything happening correctly without error. I've personally seen SC corrupt this file atleast 5 times now, so are you telling me I'm not seeing what I've clearly seen happen? Consider the user experience when it does happen. All custom changes are now gone, the file must be restored from backup (if available), or completely re-downloaded. If you don't want to make the simple change to simply write to a temp file and replace (best practice), then how about make a change so GlobalSymbolSettings.xml is written to a .bak file so people will have a way out rather than getting screwed if it does get corrupted. |